refactor(cli): group aggregator flags into AggregatorOpts

[MegaRedHand]

Stacked on #477 (refactor/cli-options-module). Review/merge that one first; this PR's base is refactor/cli-options-module, so the diff shown is only the aggregator change.

Why

--is-aggregator and --aggregate-subnet-ids are two halves of the same concern (committee aggregation). Grouping them into a dedicated struct keeps the aggregation knobs together and shrinks the flat CliOptions field list.

What

• New pub(crate) struct AggregatorOpts (clap::Args) in cli.rs holding is_aggregator + aggregate_subnet_ids.
• CliOptions nests it via #[command(flatten)], so the flags stay top-level on the command line (--is-aggregator, --aggregate-subnet-ids) — no --aggregator.* prefix.
• The requires = "is_aggregator" cross-reference still resolves: flattened arg IDs share the parent command's namespace.
• Call sites move to options.aggregator.is_aggregator / options.aggregator.aggregate_subnet_ids.

No change to the parsed CLI surface.

Verification

• cargo build -p ethlambda ✅
• cargo clippy -p ethlambda --all-targets -- -D warnings ✅
• cargo fmt ✅
• --help confirms --is-aggregator / --aggregate-subnet-ids remain top-level flags; clap validates the requires arg-graph at startup without panicking.

[github-actions]

🤖 Kimi Code Review

The diff is a clean refactoring that improves code organization without changing the CLI interface.

Correctness & Best Practices

• Line 75-98 (cli.rs): The use of #[command(flatten)] correctly groups related aggregator configuration while preserving the top-level CLI arguments (--is-aggregator, --aggregate-subnet-ids). The requires = "is_aggregator" constraint remains valid because clap flattens argument IDs into the parent namespace.
• Line 210, 228-229 (main.rs): Field access is correctly updated to use the nested options.aggregator path.

Suggestions

1. Visibility consistency (cli.rs:74): Consider whether AggregatorOpts needs to be pub(crate). Since it's flattened into CliOptions and accessed via options.aggregator.*, the struct itself could be pub (or left as pub(crate) if used elsewhere), but this is minor.
2. Documentation link (cli.rs:78): The rustdoc link [`CliOptions`] assumes CliOptions is in scope. In a separate module context, this might need a path (e.g., [`super::CliOptions`] or crate-relative), but given the current file structure, it renders correctly.

Consensus/Security Impact

None—this is purely a CLI parsing layer refactor with no changes to consensus logic, state transition functions, or cryptography.

Verdict: LGTM. Clean separation of concerns that makes the CLI structure more maintainable.

---

Automated review by Kimi (Moonshot AI) · kimi-k2.5 · custom prompt

[github-actions]

🤖 Codex Code Review

No findings.

The change in bin/ethlambda/src/cli.rs and bin/ethlambda/src/main.rs is a mechanical CLI refactor: the aggregator flags are grouped under a flattened clap::Args struct, and the two runtime consumers were updated consistently. I do not see a correctness, consensus, security, or performance regression from the diff itself. Fork choice, attestation processing, state transition, XMSS, and SSZ paths are untouched.

Residual risk: I could not run cargo check in this environment because Cargo/Rustup attempted to write to read-only ~/.rustup and ~/.cargo while syncing the toolchain and fetching leanVM, so this review is source-inspection only.

---

Automated review by OpenAI Codex · gpt-5.4 · custom prompt

[greptile-apps]

Greptile Summary

This PR groups the ethlambda aggregator CLI flags into a flattened options struct. The main changes are:

• Adds AggregatorOpts for --is-aggregator and --aggregate-subnet-ids.
• Flattens those flags into CliOptions so the CLI surface stays top-level.
• Updates startup code to read aggregator settings from options.aggregator.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
bin/ethlambda/src/cli.rs	Moves the existing aggregator flags into a flattened AggregatorOpts struct without changing their clap attributes.
bin/ethlambda/src/main.rs	Updates aggregator option reads to use the new nested options.aggregator path.

_{Reviews (1): Last reviewed commit: "refactor(cli): group aggregator flags in..." | Re-trigger Greptile}

[github-actions]

🤖 Claude Code Review

---

PR #478 — refactor(cli): group aggregator flags into AggregatorOpts

This PR is a pure structural refactoring: it extracts is_aggregator and aggregate_subnet_ids from the flat CliOptions struct into a dedicated AggregatorOpts struct, then flattens it back in via #[command(flatten)]. The CLI surface is unchanged — both flags remain top-level on the command line.

Review findings

After running all eight analysis angles (line-by-line scan, removed-behavior audit, cross-file caller trace, reuse, simplification, efficiency, altitude, and CLAUDE.md conventions) and verifying each candidate:

No actionable findings.

Specific checks that passed:

• requires = "is_aggregator" after flatten: Clap 4.x merges flattened arg IDs into the parent command namespace, so the cross-reference is still resolved correctly. The PR description documents this explicitly and confirms it was verified against --help.
• Call site completeness: Grep shows zero remaining options.is_aggregator or options.aggregate_subnet_ids direct references; all three use-sites in main.rs (lines 210, 231, 232) are correctly migrated to options.aggregator.*.
• Doc comment placement: The detailed operational doc (hot-standby model, runtime-toggle caveats) moves to AggregatorOpts where it belongs — no information is dropped.
• CLAUDE.md conventions: pub(crate) visibility, no gratuitous comments, no added abstractions beyond the task scope, correct inspect_err usage in unchanged surrounding code.

The struct-level doc comment on AggregatorOpts (lines 76–79) is well-placed and correctly explains the non-obvious clap flatten + requires interaction. This is a clean, self-consistent change.

---

Automated review by Claude (Anthropic) · sonnet · custom prompt