Skip to content

fix: skip one signature aggregation jobs #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MegaRedHand wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: skip one signature aggregation jobs #483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/blockchain/src/aggregation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,14 @@ fn build_job(

let (children, accepted_child_ids) = resolve_child_pubkeys(&child_proofs, validators);

// Skip aggregation when there's nothing to aggregate
if raw_ids.is_empty() && children.len() < 2 {
return None;
}
// Skip aggregation when there's only a single raw signature to aggregate.
if children.is_empty() && raw_ids.len() <= 1 {
return None;
}
Comment thread
MegaRedHand marked this conversation as resolved.

let keys_to_delete: Vec<(u64, H256)> = validator_sigs
.into_iter()
Expand Down
Loading