feat: Publish SupraWall Security Plugin (v0.5.0 Sanitized)#2293
Closed
wiserautomation wants to merge 1 commit into
Closed
feat: Publish SupraWall Security Plugin (v0.5.0 Sanitized)#2293wiserautomation wants to merge 1 commit into
wiserautomation wants to merge 1 commit into
Conversation
crazywoola
approved these changes
Apr 20, 2026
crazywoola
requested changes
Apr 23, 2026
Member
crazywoola
left a comment
There was a problem hiding this comment.
❌ Request Changes
Decision: Request changes
Review Status
| Check | Status | Detail | Required action |
|---|---|---|---|
PR language |
✅ Pass | PR title/body CJK ratio=0.0% (zh=0, en=368, allowed_zh<=0). | None. |
Single .difypkg |
✅ Pass | Changed package: wiserautomation/suprawall-security/suprawall-security.difypkg | None. |
Project structure |
❌ Fail | Missing files: README.md. Present: manifest.yaml, PRIVACY.md. _assets/: yes. | Include all required files in the package: manifest.yaml, README.md, PRIVACY.md, and _assets/. |
Manifest author |
✅ Pass | author is valid. | None. |
Icon validation |
✅ Pass | icon exists: _assets/icon.svg | None. |
Version check |
✅ Pass | version 0.5.0 is available. | None. |
README language |
❌ Fail | README.md not found in plugin package. | Remove Chinese characters from README.md or move translations to multilingual docs: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme |
PRIVACY.md |
✅ Pass | PRIVACY.md exists and is non-empty. | None. |
Dependency install |
✅ Pass | requirements installed successfully. | None. |
dify_plugin version |
❌ Fail | dify_plugin version must be >= 0.5.0; found 0.0.1b32. | Use dify_plugin >= 0.5.0 in the packaged plugin environment. |
Install test |
❌ Fail | Testing plugin in directory: /var/folders/yl/54qqf2s909z2kjf8_vy8sg940000gn/T/pr-2293-review2-4v_lnk35/unpacked_plugin !!! Process exited, here is the stderr: ================================================ ================================================ !!! Have you tested it... | Fix the plugin so test-plugin-install.py passes. |
Packaging test |
✅ Pass | packaging check passed. | None. |
Next steps
- Project structure: Include all required files in the package:
manifest.yaml,README.md,PRIVACY.md, and_assets/. - README language: Remove Chinese characters from
README.mdor move translations to multilingual docs: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme - dify_plugin version: Use
dify_plugin >= 0.5.0in the packaged plugin environment. - Install test: Fix the plugin so
test-plugin-install.pypasses.
Please address the issues above and push an updated submission.
Member
|
Closing as stale because there has been no response for more than 2 weeks after changes were requested. Please feel free to reopen or submit a new PR when the requested changes are ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resubmits the SupraWall Security plugin with version 0.5.0 and a clean git history (purging stale npm tokens from history). The binary includes the required PRIVACY.md (All-Caps).
1. Metadata
2. Submission Type