Skip to content

revert(web): use suspense boundary in home page - #40167

Merged
lyzno1 merged 1 commit into
mainfrom
revert/home-loading-page
Aug 7, 2026
Merged

revert(web): use suspense boundary in home page#40167
lyzno1 merged 1 commit into
mainfrom
revert/home-loading-page

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 7, 2026

Copy link
Copy Markdown
Member

This reverts commit af9d2d0.

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@lyzno1
lyzno1 requested a review from iamjoel as a code owner August 7, 2026 18:39
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. refactor labels Aug 7, 2026
@lyzno1
lyzno1 enabled auto-merge August 7, 2026 18:39
@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 7, 2026
@lyzno1 lyzno1 changed the title revert(web): use suspense boundary instead of loading.tsx in home page revert(web): use suspense boundary in home page Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.40%. Comparing base (916d7e1) to head (af3be71).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40167      +/-   ##
==========================================
- Coverage   86.44%   86.40%   -0.05%     
==========================================
  Files        5260     5103     -157     
  Lines      294775   290648    -4127     
  Branches    59025    57920    -1105     
==========================================
- Hits       254822   251131    -3691     
+ Misses      35002    34566     -436     
  Partials     4951     4951              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.10% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 added this pull request to the merge queue Aug 7, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2026
Merged via the queue into main with commit d1fa170 Aug 7, 2026
43 checks passed
@lyzno1
lyzno1 deleted the revert/home-loading-page branch August 7, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants