Skip to content

docs: clarify calendar query default range#1856

Open
gengyi1207-bit wants to merge 2 commits into
larksuite:mainfrom
gengyi1207-bit:docs/calendar-skill-default-range
Open

docs: clarify calendar query default range#1856
gengyi1207-bit wants to merge 2 commits into
larksuite:mainfrom
gengyi1207-bit:docs/calendar-skill-default-range

Conversation

@gengyi1207-bit

@gengyi1207-bit gengyi1207-bit commented Jul 11, 2026

Copy link
Copy Markdown

Summary

Clarify the default time-range guidance for calendar event queries in the Lark Calendar skill.

Changes

  • Document that agents should confirm when a user does not specify a calendar query time range.
  • Document that agents may explicitly use "the full current day" as the default range when context allows.
  • Clarify that the default day follows the user's current timezone as a local calendar day, not UTC or another timezone.

Test Plan

  • rg -n "未指定查询时间范围|今天整天|当前时区|UTC" skills/lark-calendar/SKILL.md
  • git diff --name-only -- ':!docs/superpowers/' ':!.lark-cli-harness/'
  • Harness validate: PASS
  • Harness acceptance-reviewer: PASS
  • Go tests not run: this is a Markdown skill documentation-only change with no CLI runtime behavior change.

Related Issues

  • N/A

Summary by CodeRabbit

  • Documentation
    • Clarified default behavior for schedule queries without a specified time range.
    • Added confirmation before querying today’s agenda when no time range is provided.
    • Specified that results should be grouped by date and sorted by start time.
    • Defined “today” according to the user’s local calendar day (not silently timezone-shifted).

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b75786a-97ff-42c8-981f-e807740598d6

📥 Commits

Reviewing files that changed from the base of the PR and between 0810e7a and ea2dabd.

📒 Files selected for processing (1)
  • skills/lark-calendar/SKILL.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skills/lark-calendar/SKILL.md

📝 Walkthrough

Walkthrough

The calendar skill documentation clarifies confirmation for unspecified schedule ranges, defaults execution to the user’s local day, prevents silent timezone conversion, and specifies date grouping with ascending start-time ordering.

Changes

Calendar query guidance

Layer / File(s) Summary
Schedule query defaults
skills/lark-calendar/SKILL.md
The +agenda and time-inference guidance now requires intent confirmation, uses the user’s local “today all day” range when proceeding, prevents silent timezone conversion, and orders results by date and start time.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: calendar-assistant, zhaoleibd

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the calendar query default-range clarification.
Description check ✅ Passed The description follows the required template and includes summary, changes, test plan, and related issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact labels Jul 11, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-calendar/SKILL.md`:
- Line 66: Update the agenda runtime so the user’s timezone/location is passed
through both default range construction in resolveStartEnd and date-only parsing
in common.ParseTime, ensuring “today” and date inputs use the same user-local
day. Alternatively, revise the documented default behavior to explicitly
describe process-timezone semantics, but keep the implementation and SKILL.md
behavior consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b229e85-9089-4e3c-9d50-1f8f7df72481

📥 Commits

Reviewing files that changed from the base of the PR and between 4847f06 and 0810e7a.

📒 Files selected for processing (1)
  • skills/lark-calendar/SKILL.md

Comment thread skills/lark-calendar/SKILL.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants