feat(drive): support apps in list comments#1877
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChanges
Apps comment listing
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant InputResolver
participant AppsURLParser
participant DriveCommentsAPI
CLI->>InputResolver: submit apps page URL
InputResolver->>AppsURLParser: parse /page/<token>
AppsURLParser-->>InputResolver: return apps token
InputResolver->>DriveCommentsAPI: list comments with file_type=apps
DriveCommentsAPI-->>CLI: return comment response
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
+ Coverage 74.66% 74.68% +0.02%
==========================================
Files 877 878 +1
Lines 91731 91786 +55
==========================================
+ Hits 68494 68554 +60
+ Misses 17926 17922 -4
+ Partials 5311 5310 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@8b5d19c43bbaa3f57240a1366374d5609acb42cc🧩 Skill updatenpx skills add larksuite/cli#fix/drive-list-comments-apps -y -g |
Summary
Support listing comments for Miaoda apps resources via
drive +list-comments, including/page/<token>URL parsing andfile_type=apps.Changes
appsas a supporteddrive +list-commentstype and recognize Miaoda/page/<token>URLs.--need-relationdocx-only.Test Plan
git diff --checkgo test ./shortcuts/drive -run 'TestResolveDriveListCommentsInput|TestBuildDriveListCommentsParams|TestDriveListCommentsExecuteAppsPageURL'go test ./tests/cli_e2e/drive -run TestDriveListCommentsDryRun_AppsPageURLmake unit-test(not run per request)Related Issues
Summary by CodeRabbit
New Features
drive +list-commentsnow supports Miaoda apps./page/<token>format and bare app tokens with--type apps.Bug Fixes
apps.Documentation
Tests