Document mail sender allow/block commands#1885
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe changes add schema and dry-run integration tests for user-level mail sender allowlists and blocklists, plus documentation covering list, batch creation, and batch removal commands. ChangesMail sender allow/block lists
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/schema/schema_test.go`:
- Around line 51-52: Isolate configuration state for tests using
cmdutil.TestFactory by setting LARKSUITE_CLI_CONFIG_DIR to t.TempDir() at the
beginning of TestSchemaCmd_MailSenderAllowBlockList in cmd/schema/schema_test.go
(lines 51-52) and the corresponding test in cmd/service/service_test.go (lines
126-127).
- Around line 63-65: Update the expected schema ID assertion in the schema test
to use the plural value user_mailbox.allow_senders.list, including the failure
message, so it matches the command path and mail schema naming.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 02b410fe-6c1d-4ccd-92ad-63f7611ece54
📒 Files selected for processing (3)
cmd/schema/schema_test.gocmd/service/service_test.goskills/lark-mail/SKILL.md
Change-Type: ci-fix
Adds documentation and tests for the mail sender allow/block command surface in the generated CLI metadata. The change updates the mail skill reference and covers schema and help visibility so users can discover the list, search, batch_set, and batch_delete commands.
Summary by CodeRabbit
list(keyword search),batch_create, andbatch_removewith request examples.