Preserve full mission output in the web UI - #29
Draft
hanshenmesen wants to merge 2 commits into
Draft
Conversation
Prefer the final in-mission Engineer delivery over a longer superseded message, and do not recover across a missing mission-start boundary. Co-Authored-By: GPT-5.6-Sol <noreply@anthropic.com>
Collaborator
|
I pushed a small maintainer follow-up in The historical fallback previously selected the longest Engineer message, which could surface a superseded draft, and it scanned from the start of the event window when the matching mission-start boundary was absent. The follow-up now:
Validation:
I intentionally did not rebase or regenerate the stale release artifacts in this follow-up. Please review the semantic adjustment; the branch still needs to be rebased onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
final_outputWhy
Mission completion currently flattens the Engineer handoff and slices it to 1,200 characters. Mission Control labels that value as the completed result, so long-form reports appear to end mid-sentence even though the original
engineer.progressevent still contains the full text. Role work is also capped, leaving no reliable full-deliverable path from the mission view.User impact
Long reports remain compact at first glance, but users can expand and read the complete result in the same mission view. Existing missions in the recent event window also recover their full output without being rerun.
Validation
./.venv/bin/pytest -q tests/life/test_mission_outcome.py tests/core/test_mission_view.py./.venv/bin/ruff checkon all changed Python sources and testsnpm testinfrontend/web— 176 tests passednpm run typecheckinfrontend/webpython3 -m argus_skill.release_tools.generate_event_types --checkpython -m argus_skill.release_tools.build_release