fix(windows): stabilize desktop, web, and executor startup - #37
Merged
Conversation
Accept verified venv launcher descendants during executor startup, retry transient health sidecar replacements, and reject unverified clean exits. Ensure Electron is installed after npm ci, support documented Web aliases, refresh secure frontend dependencies and artifacts, and widen Windows CI coverage. Co-Authored-By: GPT-5.6-Sol <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Windows startup across Desktop, CLI, Web, and the background executor.
The reported executor failure was reproduced from the original logs and on native Windows: the worker published a healthy runtime PID, but the parent rejected it because a virtual-environment
python.exelauncher has a different PID from its base-interpreter child. The handshake now accepts only the spawned launcher itself or a verified current descendant, preserving the foreign-process safety check.Changes
PermissionErrorfailures while replacingdaemon.health.json;npm civia Desktop postinstall;electron-logerror handling;--host/--portWeb aliases through both CLI routing layers;httpx2explicitly for the Windows TestClient suites.Testing
All listed checks pass on native Windows 11 x64. Remaining failures: none.
python -m ruff check argus_skill tests desktoprc=0, verified runtime alive, PID-bound stoprc=0, no orphannpm ci: Electron binary downloaded automatically; noElectron uninstall-c/script/timezone verificationelectron-builder --win --dirpackage-layout validationwin-unpacked/Argus.exeE2E: Desktop window + frozen WebAPI + frozen background executor start/stopargus --doctor --backend pi: all checks passednpm auditfor Web, TUI, and Desktop: 0 vulnerabilitiesRelated Issues
N/A — reproduced from the operator's Windows runtime logs.
Checklist