Refactor: extract shared CSS, split reducer, clean up dead code - #24
Merged
Merged
Conversation
- Delete dead GameHistory component and unused react.svg asset
- Extract duplicated CSS into shared.css (scoreboard, bust colors, badges, banners)
- Create BustChanceBanner component replacing duplicate IIFE blocks
- Extract flattenHandWithCancelled utility into handUtils.js
- Add createEmptyDealtCards to deckUtils.js
- Split play-mode actions into separate playModeReducer.js (~450 lines)
- Remove global SET_DIALOG in favor of local useState in components
- Standardize NAVIGATE payload to { screen, editingRound?, playerId? }
- Remove unused getDealtCards/getDeckStatus helpers
- Move test-helpers.js to test-utils/helpers.js
Fixes FLI-9
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GameHistorycomponent and unusedreact.svgassetshared.css(scoreboard styles, bust-chance colors, CPU badges, tiebreaker/cheater toggles)BustChanceBannercomponent replacing duplicate IIFE blocks inPlayRoundandRoundEntryflattenHandWithCancelledutility intohandUtils.jsandcreateEmptyDealtCardsintodeckUtils.jsplayModeReducer.jsSET_DIALOGaction in favor of localuseStateinHomeScreenandGameScreenNAVIGATEpayload to{ screen, editingRound?, playerId? }across all componentsgetDealtCards/getDeckStatushelpers and reorganize test utilsNet result: -426 lines (1000 added, 1426 removed), with cleaner separation of concerns and less duplication.
Fixes FLI-9
Test plan
npm run buildpassesnpx vitest run)🤖 Generated with Claude Code