DCompute: Inline memcmp for device array equality#5156
Open
badnikhil wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The comparison/equality hooks added in #5149 lower array
==/<to amemcmpcall (DtoArrayEqCmp_memcmp).That works on the host, but device targets have no libc to providememcmp, and there is nollvm.memcmpintrinsic to fall back on ,so the call has nothing to bind to on the device.Explanation of the Fix
equal, otherwise the unsigned difference of the first mismatching byte.
paths.
than assuming the result is still produced in memcmpBB.