Add llvm_is_fpclass (llvm.is.fpclass) to ldc.intrinsics#5157
Merged
thewilsonator merged 2 commits intoJun 24, 2026
Merged
Conversation
Contributor
Author
|
Requesting review |
thewilsonator
approved these changes
Jun 23, 2026
| if (__traits(isFloating, T)); | ||
|
|
||
| /// The ‘llvm.is.fpclass’ intrinsic returns a boolean value or vector of | ||
| /// boolean values depending on whether the first argument satisfies the |
Contributor
There was a problem hiding this comment.
this doesn't look to handle the vector return case (though I'm not sure we can or need to).
Contributor
Author
There was a problem hiding this comment.
No. I copied those docs from the LangRef.
Boolean vector output is for when you have a vector input.
Contributor
There was a problem hiding this comment.
then please update the doc to either remove reference to the vector case or add a note that it is not (yet) supported.
Contributor
Author
There was a problem hiding this comment.
Done (vector mention removed).
Something to re-evaluate if/when support for vector intrinsics gets added.
Contributor
There was a problem hiding this comment.
FWIW we have intrinsic support for vectors, but not for vector of bools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
llvm_is_fpclasstoldc.intrinsics(for scalars only).https://llvm.org/docs/LangRef.html#llvm-is-fpclass-intrinsic