[CI] geospatial: satisfy pre-commit across all addons#5
Merged
Conversation
The migration branch was pushed directly (never via PR), so the pre-commit workflow — which only runs on pull_request events — had never gated it. Running `pre-commit run --all-files` surfaces the accumulated lint debt. This commit applies the fixes: - prettier (incl. plugin-xml) and eslint --fix autoformatting across base_geoengine / geoengine_swisstopo / geoengine_drone_ortho and BRANCHES.md - eslint no-use-before-define: reorder _doRegister() above ensureProjectionsRegistered() in geoengine_swisstopo proj4_setup - whool: add missing geoengine_tools/pyproject.toml - oca-gen-addon-readme: generate the missing README.rst / static/description for geoengine_drone_ortho, geoengine_drone_ortho_swisstopo, geoengine_swisstopo, geoengine_tools and refresh the stale ones Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
pre-commitworkflow only runs onpull_requestevents. The19.0-mig-base_geoenginebranch was built via direct pushes, so pre-commit had never gated it. The first PR to open against it (#4) surfaced the whole accumulated lint debt at once.This PR runs
pre-commit run --all-filesand commits the result so the branch is green.What
@prettier/plugin-xml) + eslint--fixautoformatting acrossbase_geoengine,geoengine_swisstopo,geoengine_drone_orthoandBRANCHES.md.no-use-before-define(real error): reorder_doRegister()aboveensureProjectionsRegistered()ingeoengine_swisstopo/.../proj4_setup.esm.js(function is hoisted, behaviour unchanged).geoengine_tools/pyproject.toml.README.rst+static/description/index.htmlforgeoengine_drone_ortho,geoengine_drone_ortho_swisstopo,geoengine_swisstopo,geoengine_tools, and refresh stale ones.Verification
pre-commit run --all-files→ all hooks pass (whool, readme, prettier, eslint, ruff, pylint_odoo).Note
Overlaps slightly with #4 on
geoengine_tools(pyproject.toml,README.rst). Whichever merges second needs a trivial rebase.🤖 Generated with Claude Code