Skip to content

[IMP] base_geoengine: align with the consolidated module version#6

Merged
leNeo merged 1 commit into
19.0-mig-base_geoenginefrom
19.0-consolidate-base_geoengine
Jun 28, 2026
Merged

[IMP] base_geoengine: align with the consolidated module version#6
leNeo merged 1 commit into
19.0-mig-base_geoenginefrom
19.0-consolidate-base_geoengine

Conversation

@leNeo

@leNeo leNeo commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Why

base_geoengine on this branch lagged behind the maintained version kept on 19.0-mig-base_geoengine-consolidated. This PR brings the consolidated module in, while the branch keeps the satellite addons (geoengine_tools, geoengine_swisstopo, geoengine_drone_ortho, …).

What

The base_geoengine/ directory is replaced wholesale by the version from 19.0-mig-base_geoengine-consolidated (≈ 332 insertions / 5632 deletions — most of the deletions are slimmer vendored libs). Notable functional changes pulled in:

  • security: enforce record rules on indirect geo sub-queries
  • Odoo 19: use group_ids instead of groups_id on res.users
  • refactor geo library loading to dynamic imports
  • renderer cleanups + added model tests

Satellite modules are untouched. The renderer extension points they patch (setupControls, createHtmlControl, addSelectedClassToButton, remove*Interaction, registerInteraction, this.format, createDrawControl) all still exist in the consolidated renderer.

Verification

pre-commit run --all-files locally: all hooks pass except debug-statements and pylint_odoo, which only fail under my local Python 3.9 because base_geoengine/expressions.py uses a match statement (Python 3.10+). CI runs Python 3.11 (py_compile under 3.12 confirms the file is valid), so both pass there.

Note

⚠️ JS isn't covered by CI tests. The consolidated renderer differs by ~155 lines; a manual smoke test of the map (draw, edit, measure toolbox, swisstopo projection) is recommended after merge.

🤖 Generated with Claude Code

Replace base_geoengine in the migration branch with the version from
the 19.0-mig-base_geoengine-consolidated branch, which carries the
maintained/cleaned-up module while this branch keeps the satellite
addons (geoengine_tools, geoengine_swisstopo, geoengine_drone_ortho…).

Notable changes pulled in from the consolidated module:
- security: enforce record rules on indirect geo sub-queries
- Odoo 19: use group_ids instead of groups_id on res.users
- refactor geo library loading to dynamic imports; slimmer vendored libs
- renderer cleanups and added model tests

Satellite modules are left untouched; the renderer extension points they
patch (setupControls, createHtmlControl, addSelectedClassToButton,
remove*Interaction, registerInteraction, this.format, createDrawControl)
all still exist in the consolidated renderer.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@leNeo leNeo merged commit 584428f into 19.0-mig-base_geoengine Jun 28, 2026
4 checks passed
@leNeo leNeo deleted the 19.0-consolidate-base_geoengine branch June 28, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant