[Merged by Bors] - feat: extended canonical decomposition#40191
Closed
kebekus wants to merge 11 commits into
Closed
[Merged by Bors] - feat: extended canonical decomposition#40191kebekus wants to merge 11 commits into
kebekus wants to merge 11 commits into
Conversation
github-actions
Bot
added
the
large-import
PR summary ca6da00002Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Analysis.Complex.CanonicalDecomposition | 2004 | 2084 | +80 (+3.99%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Analysis.Complex.CanonicalDecomposition |
80 |
Declarations diff (regex)
+ CanonicalDecomp.divisor_eq_divisor
+ ECanonicalDecomp
+ Set.Subsingleton.mem_codiscreteWithin
+ _root_.MeromorphicOn.exists_ecanonicalDecomp
+ finprod_apply_ne_zero
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
15362b4).
- +13 new declarations
- −0 removed declarations
+Complex.CanonicalDecomp.divisor_eq_divisor
+Complex.ECanonicalDecomp
+Complex.ECanonicalDecomp.analyticOnNhd
+Complex.ECanonicalDecomp.casesOn
+Complex.ECanonicalDecomp.eventuallyEq
+Complex.ECanonicalDecomp.meromorphicOn
+Complex.ECanonicalDecomp.mk
+Complex.ECanonicalDecomp.ne_zero
+Complex.ECanonicalDecomp.rec
+Complex.ECanonicalDecomp.recOn
+MeromorphicOn.exists_ecanonicalDecomp
+Set.Subsingleton.mem_codiscreteWithin
+finprod_apply_ne_zeroNo changes to strong technical debt.
No changes to weak technical debt.
Current commit ca6da00002
Reference commit 1ccad003f4
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
kebekus
changed the title
j-loreaux
reviewed
Jun 10, 2026
j-loreaux
added
the
awaiting-author
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
kebekus
removed
the
awaiting-author
j-loreaux
reviewed
Jul 7, 2026
mathlib-bors
Bot
added
the
delegated
Contributor
|
✌️ kebekus can now approve this pull request until 2026-07-21 20:08 UTC (in 2 weeks). To approve and merge, reply with
|
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Collaborator
Author
|
@j-loreaux Thank you for the help! bors r+ |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jul 8, 2026
Establish the Extended Canonical Decomposition of meromorphic functions, where a complex-meromorphic function `f` on a closed disk is written, up to modification over a discrete set, as a product of a non-vanishing analytic function, canonical factors and meromorphic functions of the form `(x - const) ^ n` where `const` is on the circumference of the disk. This extended decomposition is key in the proof of the classic Poisson-Jensen formula. Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
mathlib-bors
Bot
added
the
bors-staging
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors
Bot
changed the title
mathlib-bors
Bot
removed
the
delegated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establish the Extended Canonical Decomposition of meromorphic functions, where a complex-meromorphic function
fon a closed disk is written, up to modification over a discrete set, as a product of a non-vanishing analytic function, canonical factors and meromorphic functions of the form(x - const) ^ nwhereconstis on the circumference of the disk.This extended decomposition is key in the proof of the classic Poisson-Jensen formula.