Conversation
Collaborator
|
Looks basically good modulo docs nitpicks. Also, because the PR description becomes the commit message, it would be nice to summarize the benchmark runs in the text, because they will presumably not be accessible at that URL in the time period where understanding this commit message might be useful. |
Co-authored-by: David Thrane Christiansen <david@lean-fro.org>
Member
Author
|
One remaining concern from the sf-in-lean thread: merging this will break Verso on Linux with Lean below v4.34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables
precompileModulesand documents how this can be leveraged to speed up rebuilds as a tip.No-Changelog: internal optimization detail.
We do not change Verso's benchmarking configuration at this time - it will continue to measure build times for the default setup (with native-compiled
Mainexecutables), as experienced by most users (though leanprover/verso-blueprint'svbp buildCLI should immediately benefit from this).Benchmark results with interpreted
MainandprecompileModules:Mainsince we don't compile these when interpretingMain.Raw radar data:
runner-leanNwithnproc(48?) coresrunner-leanNlimited to 4 cores (emulating GitHub's CI runners or a small laptop)