Skip to content

🧪 [Testing Improvement] Add unit tests for dateToThaiString#7

Open
lemononmars wants to merge 1 commit into
mainfrom
improve-date-testing-12922433475818139005
Open

🧪 [Testing Improvement] Add unit tests for dateToThaiString#7
lemononmars wants to merge 1 commit into
mainfrom
improve-date-testing-12922433475818139005

Conversation

@lemononmars

Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed
The dateToThaiString function in src/lib/utils/date.ts was missing tests despite being a pure function. I've added a comprehensive unit test suite using vitest to ensure correctness and prevent regressions. I also caught and fixed a small typo in the production code where the month "เมษายน" incorrectly had a leading space.

📊 Coverage: What scenarios are now tested

  • Typical dates formatting
  • Boundary months handling (January and December)
  • Single-digit and double-digit day/month parsing
  • Standard ISO strings parsing (YYYY-MM-DD)

Result: The improvement in test coverage
The codebase is now more robust with proper testing setup (vitest added as dev dependency, test script in package.json). dateToThaiString is fully tested and verified against real-world inputs.


PR created automatically by Jules for task 12922433475818139005 started by @lemononmars

- Installed `vitest` as the testing framework
- Added `"test": "vitest run"` script to `package.json`
- Created `date.test.ts` to test typical dates, boundary months, single-digit vs double-digit parsing, and ISO strings
- Fixed a minor typo in `date.ts` where "เมษายน" (April) had a leading space

Co-authored-by: lemononmars <26631189+lemononmars@users.noreply.github.com>
@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codebreaker Ready Ready Preview, Comment Jun 14, 2026 10:07pm

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant