Add AMBAR music dataset to Lenskit - #1187
Conversation
mdekstrand
left a comment
There was a problem hiding this comment.
A few things this needs off the bat:
- tests (tagged with
@mark.realdata, see the Amazon and Steam load tests for examples). The tests should probably look at it indata/ambar. - adding to
data/convert.py. - adding to the data conversion CLI test script.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
- Coverage 90.37% 90.17% -0.21%
==========================================
Files 261 262 +1
Lines 17376 17417 +41
==========================================
+ Hits 15704 15705 +1
- Misses 1672 1712 +40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Now that the tests are there, they are failing: https://jynx.mde.one/repos/1/pipeline/54/3 The test environment has a copy of the |
|
The error is due to duplicate Also, there are 8 different
1,765 of 3,311,462 total ratings (0.053%) from these 13 users are now excluded. Let me know if excluding is the right approach here. |
|
Probably better to keep the ratings with missing users, those users just won't have attributes. On the conflicts, dropping is probably fine, we could also keep them and just pick the first or last record (if the records have timestamps, we should pick the last one by timestamp). |
|
@mdekstrand just FYI, for security reasons I have to manually approve the woodpecker tests every time they run. They can't be re-triggered from within a push. |
|
This dataset does not have timestamps. |
issue #1142
amber.pyto load data from its pathdescribe.pyso imported dataset can be described with the existing describe command