feat(loggers): add configurable log level (#56) - #324
Merged
Merged
Conversation
Add a non-breaking WithLevel option to the provided Text and ECS loggers so messages below the configured severity are discarded. Defaults to LevelInfo (logs everything), preserving current behavior. Fixes #56 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #56 — the provided loggers had no way to set a severity threshold; every message was always emitted.
Change
Adds a non-breaking
WithLevel(...)functional option to theTextandECSloggers:LevelInfo(default) — logs info, warning and error (unchanged behavior)LevelWarning— logs warning and error onlyLevelError— logs error onlyNewText()/NewECS()keep working with no arguments. A sharedOptiontype letsWithLevelapply to either logger.Test
level_test.gocaptures stdout and asserts that lower-severity messages are discarded at each level and that the default logs everything. It fails to compile before the change (noWithLevel/Level*) and passes after.🤖 Generated with Claude Code