cert-checker: fix logging & push metrics#8763
Merged
Merged
Conversation
ezekiel
previously approved these changes
May 26, 2026
ezekiel
requested review from
a team and
aarongable
and removed request for
a team
Contributor
|
@lenaunderwood22, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
aarongable
reviewed
May 28, 2026
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
aarongable
previously approved these changes
May 28, 2026
ezekiel
previously approved these changes
May 28, 2026
beautifulentropy
requested changes
Jun 3, 2026
aarongable
previously approved these changes
Jun 5, 2026
aarongable
left a comment
aarongable
left a comment
Contributor
There was a problem hiding this comment.
LGTM with some nits / test improvements.
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
aarongable
previously approved these changes
Jun 10, 2026
beautifulentropy
requested changes
Jun 12, 2026
Co-authored-by: Samantha Frank <hello@entropy.cat>
Co-authored-by: Samantha Frank <hello@entropy.cat>
Co-authored-by: Samantha Frank <hello@entropy.cat>
beautifulentropy
approved these changes
Jun 15, 2026
aarongable
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update cert-checker to log each bad cert individually, rather than all together in a single blob. This meshes better with our log processing infrastructure, and ensures the blob doesn't become so large that it gets truncated.
Also allow cert-checker to be configured with a prometheus push gateway URL, to which it will directly export statistics about the number of certs it checked. This allows us to get rid of the wrapper script which currently computes and pushes these metrics.
Fixes #8753