crl-storer: use IfMatch to do a compare-and-swap when uploading#8791
Merged
Conversation
beautifulentropy
requested changes
Jun 11, 2026
jsha
approved these changes
Jun 11, 2026
beautifulentropy
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "IfMatch" field of the PutObjectRequest causes the S3 server to return 412 Precondition Failed if the existing object at this path does not have the matching ETag. ETags are opaque unique values that change with each version of the file, so this acts as a compare-and-swap, to ensure that this upload is not racing against another simultaneous upload.
High-level S3 docs: https://docs.aws.amazon.com/AmazonS3/latest/userguide/conditional-requests.html
If-Match header standard: https://datatracker.ietf.org/doc/html/rfc7232