ci: restore Fly review deployments - #48
Closed
lewxdev wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
closing as superseded by #50, whose equivalent CI fix is already on main. |
lewxdev
added a commit
that referenced
this pull request
Aug 14, 2026
Prompt: adjust the stack, #48 is unnecessary that was already fixed, we can just pull the latest changes Co-authored-by: Codex <codex@openai.com>
Prompt: go ahead and fix everything here, but keep each area should be a single slice in a $gh-stack, you can make each area a subagent too Co-authored-by: Codex <codex@openai.com>
lewxdev
added a commit
that referenced
this pull request
Aug 15, 2026
* build: move runtime to Node.js 24 Prompt: go ahead and fix everything here, but keep each area should be a single slice in a $gh-stack, you can make each area a subagent too Co-authored-by: Codex <codex@openai.com> * docs: require Node.js 24 locally Prompt: adjust the stack, #48 is unnecessary that was already fixed, we can just pull the latest changes Co-authored-by: Codex <codex@openai.com> * build: pin Node.js development versions Prompt: ```json { "name": "mmmines", "private": true, "engines": { "node": ">=24" }, "scripts": { ``` please use `devEngines`, not `engines` they have different meanings, no? and it should be exact, pinned to the precise version of `@types/node` that is currently available for node 24 Co-authored-by: Codex <codex@openai.com> * build: rely on the devEngines failure default Prompt: ```json "devEngines": { "runtime": { "name": "node", "version": "24.18.0", "onFail": "error" } } ``` onFail is not necessary here, it's default Co-authored-by: Codex <codex@openai.com> --------- Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
status
closed as superseded by #50, which landed the equivalent Fly review-action fix on
main.original scope
superfly/fly-pr-review-apps@1.6.0