Conversation
Owner
|
gcd and lcm should not be in dsp_math because they are built-in functions. And they always return positive numbers because the representation of fractions in this language always has positive denominators. |
Collaborator
Author
|
As far as I know, the meaning of gcd/lcm is not necessarily connected to denominators, there is no concept of denominators for integers, strictly speaking. Just my 2c. |
Owner
|
When you divide two integers in this language, a Fraction is returned. gcd and lcm are used to simplify the fraction. The representation of Fraction keeps the denominator always positive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my improved implementation of lcm and gcd. It should obey the respective lattice laws. The tests should pass posting only true. I was not yet able to run them, because I can only use the REPL, and it doesn't allow me to override basic functions, as it seems.