fix: blockchain.block.header returns plain hex string when cp_height is zero#745
Merged
evoskuil merged 2 commits intolibbitcoin:masterfrom May 8, 2026
Merged
fix: blockchain.block.header returns plain hex string when cp_height is zero#745evoskuil merged 2 commits intolibbitcoin:masterfrom
evoskuil merged 2 commits intolibbitcoin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the Electrum protocol spec, blockchain.block.header must return a
plain hex string when cp_height is 0. The shared blockchain_block_headers()
implementation was unconditionally wrapping the result in an object,
causing Electrum clients (e.g. Sparrow) to fail parsing the response.
Two fixes in blockchain_block_headers():
std::string via send_result() instead of building an object_t.
"hex" is only correct for the plural (concatenated) response.