SIV properly handle zero AD components#777
Open
karel-m wants to merge 1 commit into
Open
Conversation
sjaeckel
reviewed
Jul 21, 2026
sjaeckel
left a comment
sjaeckel
left a comment
Member
There was a problem hiding this comment.
This has been discussed on the IETF ML [0] and FMU it was unconclusive.
Now I'm not sure if merging this would make our implementation worse, since we already allow a zero-length nonce...
[0] https://mailarchive.ietf.org/arch/msg/cfrg/Gu5cyorHPLrQ_CGYe775Xc6SV1c/
Member
Author
|
I did not look into it that deeply. I mainly wanted to be compatible with OpenSSL SIV implementation. You are right, it may need more investigation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an SIV corner case that occurs when zero AD components are used.
Checklist