Skip to content

fix(sync): refresh catalog for side profiles when Codex injection is OFF - #1931

Draft
harryzhou2000 wants to merge 1 commit into
lidge-jun:devfrom
harryzhou2000:fix/sync-catalog-side-profile
Draft

fix(sync): refresh catalog for side profiles when Codex injection is OFF#1931
harryzhou2000 wants to merge 1 commit into
lidge-jun:devfrom
harryzhou2000:fix/sync-catalog-side-profile

Conversation

@harryzhou2000

@harryzhou2000 harryzhou2000 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Explicit ocx sync (and ocx sync-cache) now refresh the catalog and models cache even when the Codex integration toggle is OFF or an external model_provider owns config.toml.

Rationale: users may consume the OpenCodex catalog through a custom side profile without injection. The refresh is harmless in those modes because config, journal, and history are never touched (new catalog-only sync status). POST /api/sync, startup, and ensure keep the existing OFF skip.

Tests: unit tests for the catalog-only and external-provider paths, models-cache override test, and updated composed-acceptance coverage.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • PR description needs work (thin).

What to do

  • Add a real Summary and Test plan to the PR description.
  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ All CI tests are green on my local testing.
  • ⬜ I pushed my PR to the latest dev commit.
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.
@harryzhou2000 Tick the boxes once your local CI is green, your branch is on the latest dev commit, and every correct Codex and CodeRabbit finding is resolved.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8a7fae34-e7e1-47e6-a46a-0b117778b27c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant