feat: custom fees - #855
Conversation
5e68855 to
f1d882d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7387849ebc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c32881d60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4b0aab6 to
e9cb357
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 074f9ed9ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| config.customFeeRegistryConfig.feeModifiers.push( | ||
| CurveFeeModifierConfig({ curveId: 0, value: 2_500, negative: true }) | ||
| ); |
There was a problem hiding this comment.
Populate positive 1,250-BP modifiers for the curves created for the Public Good, Decentralization, Extra Effort, and DVT Plus gates (curve IDs 2, 3, 4, and 6 in this deterministic deployment). Those gates still configure a 10,000-BP reward share, but this block now initializes only curve 0, so getEffectiveFee returns the 8,750-BP base fee for their operators and underpays them once fee reports consume this registry. Fresh evidence beyond the earlier empty-registry comment is that curve 0 has now been populated while all positive modifiers remain absent.
AGENTS.md reference: AGENTS.md:L73-L75
Useful? React with 👍 / 👎.
| /// @notice Per-operator fee discounts and the allocation weight boost derived from them. See | ||
| /// ICustomFeeRegistry for the model. |
There was a problem hiding this comment.
Run forge doc and commit the generated output: this commit adds CustomFeeRegistry, StepwiseWeightBoost, and their interfaces with extensive new NatSpec, but contains no docs/src changes, leaving the checked-in generated documentation without these APIs and stale for the modified providers.
AGENTS.md reference: AGENTS.md:L12-L15
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 participants
Description
Checklist
just coverage)