Conversation
Run as non-privileged user Option for Systemd sandboxing Option for settings are encrypted at rest, and decrypt at runtime, just like lambda deployment do Also updated the structure of the deployment to separate the code from the configs and the working directory.
| public open val additionalPackages: List<String> = emptyList() | ||
|
|
||
| public enum class JavaVersion { | ||
| `8`, |
| * Caveat: if required settings are missing, `loadFromFile` writes `settings.suggested.json` with the | ||
| * decrypted values into the working directory, putting them on disk in plaintext. | ||
| */ | ||
| public open val encryptSettingsAtRest: Boolean get() = false |
Contributor
There was a problem hiding this comment.
why make this optional?
| protected fun StringBuilder.systemD() { | ||
| // An unprivileged user cannot bind below 1024; grant exactly that capability when needed. | ||
| val bindsPrivilegedPort = appPort < 1024 | ||
| val capabilities = if (bindsPrivilegedPort) "AmbientCapabilities=CAP_NET_BIND_SERVICE" else "" |
Contributor
There was a problem hiding this comment.
should we just outright disallow using the privileged port for the app server?
should the app server port even be configurable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run as non-privileged user
Option for Systemd sandboxing
Option for settings are encrypted at rest, and decrypt at runtime, just like lambda deployment do
Also updated the structure of the deployment to separate the code from the configs and the working directory.
Also the java version is now configurable.