Refresh SKILL.md for v2.1 tool surface, fix marketplace.json skills path, adopt #12's path-resolution fixes - #17
Conversation
…json skills path (closes lightpanda-io#16)
…l/bin, correct CDP connection limit Co-authored-by: Scott Taylor <scott.c.taylor@mac.com>
arrufat
left a comment
There was a problem hiding this comment.
Thanks for the thorough refresh — I verified most of this against the browser source and a live MCP connection, and the surface documentation all checks out: the 31-tool MCP list matches the live server exactly, the new fetch/serve flags and defaults match Config.zig, the --port/--cdp-port exclusivity and its rationale match main.zig, the LP domain additions exist, and the ${CLAUDE_SKILL_DIR} / skills: ["./"] / frontmatter changes match the Claude Code docs. The marketplace and PATH-resolution fixes are good to land.
Two factual issues to fix before merge, and one structural point worth discussing — all inline below.
…avior, allowed-tools scoping, puppeteer snippet note)
…rim the hand-written PandaScript section (addresses arrufat's PR review comment on duplicated semantics)
|
Thanks for the thorough review, @arrufat. Addressed all five points. Replies with the specifics are on each of your inline comments. Pushed in Specifically, I vendored the browser repo's generated Two open items in the vendored
|
|
Wasn't that addressed here already? |
Ah yes, my bad, missed that. |
What & why
Brings SKILL.md up to date with the current MCP tool surface (search, tree, nodeDetails, findElement, extract, sessions, PandaScript replay, agent mode) and fixes several real bugs found while doing it.
Changes
lightpanda help <command>on the latest nightly..claude-plugin/marketplace.json'sskillsfield to point at a directory instead of./SKILL.md— closes marketplace.json: skills entry should be a directory path, not "./SKILL.md" #16.${CLAUDE_SKILL_DIR}-based install instructions for Claude Code, with a plain fallback for other agent runtimes, soscripts/install.shresolves correctly when this skill runs as a plugin (cwd isn't the skill's own directory in that case).lightpandavia PATH lookup (bare command name) instead of hardcoding~/.local/bin/lightpanda, including in the MCP JSON configs — drops thesh -c "exec ..."wrapper entirely, since it was only ever needed to expand$HOME, andspawn()/execvpresolve a bare command via PATH without a shell regardless (verified with a no-shell subprocess call). The hardcoded path broke for anyone who installed via Homebrew, AUR, or a.debpackage rather thanscripts/install.sh, which this PR also documents as alternatives. Adopts the diagnosis from fix MCP path resolution (addresses #10), CDP connection limit, Playwright signature #12 (not cherry-picked directly — this branch had diverged too far for a clean apply — see the commit for co-author credit).lightpanda help <command>plus the liverun-locally/commands/*guide pages, and the PandaScript reference at the existing live usage page, instead of linking to docs pages that only exist in an unmerged docs-repo PR.Notes for reviewers