リファクタリング Phase 3: ツーリング整備(ameba / CI / spec)#88
Conversation
There was a problem hiding this comment.
Code Review
This pull request cleans up the project structure by removing Travis CI configuration, adding the linter Ameba to development dependencies, and renaming rescued exception variables from err to error for better clarity. It also introduces comprehensive unit tests for the GitHub and Slack models. Regarding the feedback, it is recommended to provide a fallback (such as error.class.name) when error.message is nil in src/runtime/lambda.cr to avoid returning a null error field and to improve debuggability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
f86ca5f to
819971c
Compare
45ca47f to
380e1f9
Compare
819971c to
bbc54ea
Compare
380e1f9 to
fba8a7f
Compare
a697d1b to
7d39fb7
Compare
fba8a7f to
c895371
Compare
- add ameba 1.6 as a development dependency and satisfy its lints - fix broken spec_helper (required a non-existent file) and replace the placeholder spec with model unit tests (Subject#color/#update?/#comment_url, Notification#mention?, JSON parsing, Slack serialization) - add GitHub Actions CI running format check / ameba / spec - remove obsolete .travis.yml; gitignore built bin/ refs #84 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7d39fb7 to
9c68868
Compare
c895371 to
16f37de
Compare
Part of #84(3分割 PR の 3/3)
ツーリングとテストの整備。
false.should eq(true))をモデルのユニットテストに置換.travis.ymlを削除、ビルド成果物bin/を gitignore検証:
crystal spec11 examples 0 failures /ameba13 inspected 0 failures。🤖 Generated with Claude Code