Skip to content

リファクタリング Phase 3: ツーリング整備(ameba / CI / spec)#88

Merged
limit7412 merged 3 commits into
masterfrom
refactor/phase-3-tooling
Jun 15, 2026
Merged

リファクタリング Phase 3: ツーリング整備(ameba / CI / spec)#88
limit7412 merged 3 commits into
masterfrom
refactor/phase-3-tooling

Conversation

@limit7412

Copy link
Copy Markdown
Owner

Part of #84(3分割 PR の 3/3)

⚠️ base は refactor/phase-2-design(PR #87)。Phase 1 → 2 → 3 の順でマージしてください。

ツーリングとテストの整備。

  • ameba 1.6 を development_dependency に追加し指摘を解消
  • コンパイル不能だった spec(存在しないファイルを require)を修正し、プレースホルダ(false.should eq(true))をモデルのユニットテストに置換
  • GitHub Actions CI(format / ameba / spec)を追加
  • 死んでいた .travis.yml を削除、ビルド成果物 bin/ を gitignore

検証: crystal spec 11 examples 0 failures / ameba 13 inspected 0 failures。

🤖 Generated with Claude Code

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the project structure by removing Travis CI configuration, adding the linter Ameba to development dependencies, and renaming rescued exception variables from err to error for better clarity. It also introduces comprehensive unit tests for the GitHub and Slack models. Regarding the feedback, it is recommended to provide a fallback (such as error.class.name) when error.message is nil in src/runtime/lambda.cr to avoid returning a null error field and to improve debuggability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/runtime/lambda.cr Outdated
@limit7412 limit7412 force-pushed the refactor/phase-2-design branch from f86ca5f to 819971c Compare June 15, 2026 06:13
@limit7412 limit7412 force-pushed the refactor/phase-3-tooling branch from 45ca47f to 380e1f9 Compare June 15, 2026 06:13
@limit7412 limit7412 force-pushed the refactor/phase-2-design branch from 819971c to bbc54ea Compare June 15, 2026 06:29
@limit7412 limit7412 force-pushed the refactor/phase-3-tooling branch from 380e1f9 to fba8a7f Compare June 15, 2026 06:29
@limit7412 limit7412 force-pushed the refactor/phase-2-design branch from a697d1b to 7d39fb7 Compare June 15, 2026 06:50
@limit7412 limit7412 force-pushed the refactor/phase-3-tooling branch from fba8a7f to c895371 Compare June 15, 2026 06:50
- add ameba 1.6 as a development dependency and satisfy its lints
- fix broken spec_helper (required a non-existent file) and replace the
  placeholder spec with model unit tests (Subject#color/#update?/#comment_url,
  Notification#mention?, JSON parsing, Slack serialization)
- add GitHub Actions CI running format check / ameba / spec
- remove obsolete .travis.yml; gitignore built bin/

refs #84

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@limit7412 limit7412 force-pushed the refactor/phase-2-design branch from 7d39fb7 to 9c68868 Compare June 15, 2026 06:54
@limit7412 limit7412 force-pushed the refactor/phase-3-tooling branch from c895371 to 16f37de Compare June 15, 2026 06:54
Base automatically changed from refactor/phase-2-design to master June 15, 2026 10:14
limit7412 and others added 2 commits June 15, 2026 19:16
Address review feedback on PR #88: when error.message is nil the Lambda
error response field would be null, hurting debuggability. Fall back to
the exception class name.

refs #84

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@limit7412 limit7412 merged commit 8fa4b8e into master Jun 15, 2026
2 checks passed
@limit7412 limit7412 deleted the refactor/phase-3-tooling branch June 15, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant