fix(discussions): forward parent entity id when replying to a thread#227
Open
jjuraszek wants to merge 1 commit into
Open
fix(discussions): forward parent entity id when replying to a thread#227jjuraszek wants to merge 1 commit into
jjuraszek wants to merge 1 commit into
Conversation
replyToDiscussion built the CommentCreateInput with only parentId + body, omitting the entity id (issueId/projectId/initiativeId) that Linear requires even on a threaded reply, so every reply failed with: Argument Validation Error - Exactly one of ... issueId must be defined. The thread context fetched by assertRootDiscussionThread already carries all three ids; forward the right one via the existing getDiscussionThreadEntity helper. No extra network call. Closes linearis-oss#226
iamfj
approved these changes
Jun 11, 2026
iamfj
left a comment
iamfj
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for your contributon!
Member
|
The CI issue seems to be unrelated to your change. Ill take care of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
linearis issues reply <root-thread-id> --body "..."always fails:replyToDiscussionbuilt theCommentCreateInputwith onlyparentId+body. Linear'scommentCreaterequires the parent entity id (issueId/projectId/initiativeId) in addition toparentId, even for a threaded reply. Root comments viaissues discusswork becausestartIssueDiscussionpassesissueId; only the reply path was missing it.Fix
assertRootDiscussionThreadalready fetches the thread viaGetDiscussionCommentContext, which selects all three entity ids. Capture its return value (previously discarded) and forward the correct id using the existinggetDiscussionThreadEntityhelper. No extra network call.Test
Tightened the existing
replyToDiscussionhappy-path test to assert the second request forwardsissueIdalongsideparentId.tsc --noEmitclean,biome checkclean on both files, full discussion-service suite green (39/39).(The unrelated
calver-pluginunit test fails identically on a cleanmaincheckout - date-based versioning, untouched here.)Closes #226