Safer load/store_interleaved#245
Merged
Merged
Conversation
LaurenzV
approved these changes
Jun 17, 2026
Collaborator
There was a problem hiding this comment.
LGTM, if you want to be really thorough it might be good to rerun the pack_block benchmark on Vello to see whether this causes any change on x86, since it uses those methods. But you don't have to, I'll redo the benchmarks again anyway before bumping fearless_simd in vello, so if it causes issue I'll notice it then. 😄
Shnatsel
added a commit
to Shnatsel/fearless_simd
that referenced
this pull request
Jun 17, 2026
Includes regenerated AVX-512 interleaved load/store output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expunge unsafe code from load_interleaved and store_interleaved implementations on x86 and WASM.
NEON is implemented via a call to an intrinsic, so it can't be made any safer.