[default values] Implement ReadBridge.apply without an Iceberg fork - #679
Open
cbb330 wants to merge 2 commits into
Open
[default values] Implement ReadBridge.apply without an Iceberg fork#679cbb330 wants to merge 2 commits into
cbb330 wants to merge 2 commits into
Conversation
6 tasks
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
2 times, most recently
from
August 12, 2026 23:44
27edc5d to
4f25ef4
Compare
cbb330
force-pushed
the
chbush/read-bridge-sanitize-on-write
branch
from
August 12, 2026 23:57
d101fcd to
693b61b
Compare
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
from
August 12, 2026 23:57
4f25ef4 to
e68a724
Compare
cbb330
force-pushed
the
chbush/read-bridge-sanitize-on-write
branch
from
August 13, 2026 00:19
693b61b to
108b7df
Compare
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
from
August 13, 2026 00:19
e68a724 to
171134f
Compare
cbb330
force-pushed
the
chbush/read-bridge-sanitize-on-write
branch
from
August 13, 2026 00:37
108b7df to
dcc7edb
Compare
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
from
August 13, 2026 00:37
171134f to
7829367
Compare
cbb330
force-pushed
the
chbush/read-bridge-sanitize-on-write
branch
from
August 13, 2026 02:36
dcc7edb to
ff60798
Compare
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
from
August 13, 2026 02:36
7829367 to
a79c316
Compare
cbb330
force-pushed
the
chbush/read-bridge-sanitize-on-write
branch
from
August 13, 2026 02:48
ff60798 to
a5571f8
Compare
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
3 times, most recently
from
August 13, 2026 05:29
01a1468 to
3793274
Compare
17 tasks
cbb330
force-pushed
the
chbush/read-bridge-sanitize-on-write
branch
from
August 13, 2026 05:42
f05903f to
9d1bb96
Compare
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
2 times, most recently
from
August 13, 2026 05:52
4c6f354 to
a64ea0f
Compare
cbb330
force-pushed
the
chbush/read-bridge-sanitize-on-write
branch
from
August 13, 2026 06:10
253129c to
7c005b2
Compare
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
from
August 13, 2026 06:10
a64ea0f to
4be6d59
Compare
cbb330
changed the base branch from
chbush/read-bridge-sanitize-on-write
to
chbush/read-bridge-policy-ramp
August 13, 2026 22:27
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
2 times, most recently
from
August 13, 2026 22:36
08551a4 to
145297f
Compare
cbb330
changed the base branch from
chbush/read-bridge-policy-ramp
to
chbush/read-bridge-sanitize-on-write
August 13, 2026 22:36
| try { | ||
| return MAPPER.readTree(json); | ||
| } catch (JsonProcessingException e) { | ||
| throw new IllegalStateException("read-bridge: invalid json", e); |
Contributor
There was a problem hiding this comment.
any reason we are using sneaky throws vs typed?
Collaborator
Author
There was a problem hiding this comment.
quick answer: i believe this is because we catch illegalstateexception at a higher level so that it doesn't trigger retries. i will confirm in a bit.
cbb330
force-pushed
the
chbush/read-bridge-sanitize-on-write
branch
from
August 13, 2026 23:56
4ad3f14 to
b8a8a8b
Compare
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
from
August 13, 2026 23:56
145297f to
17b3d21
Compare
2 tasks
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
from
August 14, 2026 04:43
17b3d21 to
d7edc72
Compare
Overlay stamped column defaults onto schema field objects by field-id using the sanitize JSON helpers.
Apply puts overlays on the in-memory schema; constructMetadataRequestBody must not strip them. Skip-reload still sends the bound overlay. Unstamped writer defaults stay on the wire.
cbb330
force-pushed
the
chbush/read-bridge-apply
branch
from
August 14, 2026 20:41
d7edc72 to
950f3f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #678 (server handshake + drop), stacked on #674 → #668 → #645.
Finish the client half of the column-default read bridge: turn server-stamped
configinto IcebergNestedField.initialDefaultat metadata load — without forking Iceberg.#678 lands first so apply is never in tree without the drop. Overlays sit on
metadata.schema(); the first write after a bridged load would persist them unless the server already strips them.ReadBridge.from(config)indoRefresh/ before IOopenhouse.read-bridge.column-default.<fieldId>(kept from #668, off the retry path)ReadBridge.apply(raw)inloadMetadataHow apply works
Patch
initial-defaultonto schema field objects by field-id in metadata JSON. No Iceberg fork.Failure policy (mirrors the server encoder):
rawunchangedIllegalStateException)openhouse.read-bridge.*keySemantics notes:
Changes
ReadBridge.applyoverlaysinitialDefaultReadBridgeTest: single/multi-schema overlay, nested fields, gaps, fail-loud bind, inert path;OpenHouseTableOperationsTest: PUT still sends stampedinitial-defaultTesting Done
./gradlew :integrations:java:iceberg-1.2:openhouse-java-itest:test --tests '*ReadBridgeTest' --tests '*OpenHouseTableOperationsTest'Additional Information
Stack
ReadBridge.apply