BUG: add strace package as a RHEL/CentOS and Fedora dependency - #124
Closed
rprobaina wants to merge 1 commit into
Closed
BUG: add strace package as a RHEL/CentOS and Fedora dependency#124rprobaina wants to merge 1 commit into
rprobaina wants to merge 1 commit into
Conversation
The strace tool is invoked in the signal test, as shown in the code
snippet below.
signal/test:
...
98 # Generate a ptrace event
99 $result = system("strace -p $task2_pid >/dev/null 2>&1");
100 ok( $result, 0 ); # Was the ptrace command successful?
...
However, the strace package is not installed by default in recent
RHEL/CentOS and Fedora distros. This missing dependency results in
a signal test failure below:
signal/test .. 2/8 # Test 5 got: "32512" (signal/test at line 100)
Expected: "0" signal/test line 100 is: ok( $result, 0 ); # Was the ptrace
command successful? Test 8 got: "0" (signal/test at line 142) Expected: "1"
signal/test line 142 is: ok( $found_ptrace, 1 ); # Was the ptrace found?
signal/test .. Failed 2/8 subtests
This commit adds the strace package in both RHEL/CentOS and Fedora
dependency lists in order to avoid this issue in the future.
Signed-off-by: Ricardo Robaina <rrobaina@redhat.com>
pcmoore
changed the title
Contributor
|
Merged via 54a8522, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strace tool is invoked in the signal test, as shown in the code snippet below.
signal/test:
...
98 # Generate a ptrace event
99 $result = system("strace -p $task2_pid >/dev/null 2>&1");
100 ok( $result, 0 ); # Was the ptrace command successful?
...
However, the strace package is not installed by default in recent RHEL/CentOS and Fedora distros. This missing dependency results in a signal test failure below:
signal/test .. 2/8 # Test 5 got: "32512" (signal/test at line 100)
Expected: "0" signal/test line 100 is: ok( $result, 0 ); # Was the ptrace
command successful? Test 8 got: "0" (signal/test at line 142) Expected: "1"
signal/test line 142 is: ok( $found_ptrace, 1 ); # Was the ptrace found?
signal/test .. Failed 2/8 subtests
This commit adds the strace package in both RHEL/CentOS and Fedora dependency lists in order to avoid this issue in the future.
Signed-off-by: Ricardo Robaina rrobaina@redhat.com