rmtfs.service: Only start if dev node present#35
Open
lool wants to merge 1 commit into
Open
Conversation
Allow having the rmtfs service present but not started on devices which don't have a /dev/qcom_rmtfs_mem1 by starting only if this node is present. This allows creating generic images, without reporting an error because the service can't start when the device node is lacking. Fixes: linux-msm#34 Reported-by: Agathe Porte <agathe.porte@oss.qualcomm.com> Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Author
|
Tested on VENTUNO Q and UNO Q with qcom-deb-images. VENTUNO Q: "systemctl status rmtfs" shows that this service was skipped; status is degraded due to another service (qbootctl) present in qcom-deb-images, but this seems to work as desired. UNO Q: rmtfs started as usual before and after these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow having the rmtfs service present but not started on devices
which don't have a /dev/qcom_rmtfs_mem1 by starting only if this
node is present. This allows creating generic images, without
reporting an error because the service can't start when the device
node is lacking.
Fixes: #34