feat: add key state notification applet for Wayland#1614
Conversation
There was a problem hiding this comment.
Sorry @18202781743, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
1. Create a new dde-key-notify applet to monitor Caps Lock and Num Lock states on Wayland 2. Implement a Wayland client extension to listen for keyboard modifier state changes via the treeland-keyboard-state-notify-protocol 3. Integrate with DConfig to control Caps Lock toggle OSD display 4. Send OSD notifications through DBus (org.deepin.dde.shell) when lock states change 5. Add build system integration and installation rules for the new applet Log: Added keyboard state notification support for Wayland to display OSD when Caps Lock and Num Lock states change Influence: 1. Test on Wayland session: toggle Caps Lock and verify OSD appears/ disappears correctly 2. Test on X11 session: verify no OSD is shown (feature is Wayland-only) 3. Test Num Lock toggle and verify OSD notification 4. Verify Caps Lock toggle OSD can be disabled via DConfig (org.deepin.dde.daemon/org.deepin.dde.daemon.keyboard/capslockToggle) 5. Verify package installation completes successfully 6. Test multiple rapid toggles to ensure no crashes or missed notifications feat: 添加 Wayland 下的键盘状态通知小程序 1. 创建新的 dde-key-notify 小程序,用于监控 Wayland 下的大写锁定和数字锁 定键状态 2. 实现 Wayland 客户端扩展,通过 treeland-keyboard-state-notify 协议监听 键盘修饰键状态变化 3. 集成 DConfig 以控制大写锁定键 OSD 显示 4. 当锁定状态变化时通过 DBus(org.deepin.dde.shell)发送 OSD 通知 5. 添加构建系统集成和安装规则 Log: 添加 Wayland 键盘状态通知功能,大写锁定和数字锁定状态变化时显示 OSD Influence: 1. 在 Wayland 会话中测试:切换大写锁定键,验证 OSD 正确显示/消失 2. 在 X11 会话中测试:验证不显示 OSD(该功能仅支持 Wayland) 3. 测试数字锁定键切换,验证 OSD 通知 4. 通过 DConfig(org.deepin.dde.daemon/org.deepin.dde.daemon.keyboard/ capslockToggle)验证大写锁定 OSD 可被禁用 5. 验证软件包安装完成 6. 测试快速多次切换,确保无崩溃或丢失通知 PMS: TASK-390457
deepin pr auto review你好!我是CodeGeeX。我已仔细审查了你提交的Git Diff。本次变更为DDE Shell新增了一个键盘状态(CapsLock/NumLock)Wayland通知插件,整体结构清晰,逻辑基本合理。但在代码细节、健壮性、安全性和构建配置方面,有一些值得注意和改进的地方。 以下是具体的审查意见: 1. 语法与逻辑
2. 代码质量
3. 代码性能
4. 代码安全
5. 构建与打包
总结代码整体质量不错,主要风险点在于 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
states on Wayland
state changes via the treeland-keyboard-state-notify-protocol
states change
applet
Log: Added keyboard state notification support for Wayland to display
OSD when Caps Lock and Num Lock states change
Influence:
disappears correctly
(org.deepin.dde.daemon/org.deepin.dde.daemon.keyboard/capslockToggle)
notifications
feat: 添加 Wayland 下的键盘状态通知小程序
定键状态
键盘修饰键状态变化
Log: 添加 Wayland 键盘状态通知功能,大写锁定和数字锁定状态变化时显示 OSD
Influence:
capslockToggle)验证大写锁定 OSD 可被禁用
PMS: TASK-390457