tests/protocols: add 24 standard wayland-protocols tests served by Treeland by deepin-wm · Pull Request #1336 · linuxdeepin/treeland

deepin-wm · 2026-08-26T01:50:11Z

Summary

Add 24 standard wayland-protocols tests covering every protocol Treeland provides at runtime via wlroots (wayland-protocols 1.49.0-1).

Coverage levels

Level	Count	Protocols
E (end-to-end)	8	xdg-output, xdg-dialog, xdg-toplevel-tag, fractional-scale, single-pixel-buffer, viewporter, alpha-modifier, ext-session-lock
P (protocol/resource)	16	ext-idle-notify, xdg-activation, idle-inhibit, xdg-decoration, content-type, tearing-control, relative-pointer, pointer-constraints, xdg-foreign, security-context, linux-dmabuf, tablet, cursor-shape, xwayland-shell, presentation-time, and others

E-level tests

Each E-level test reads real production object state over the server bridge and cross-checks it against client-side protocol observation:

xdg-output: client logical_position/logical_size vs real WOutput::position()/effectiveSize()
xdg-dialog: real SurfaceWrapper::modal() flips false → true after set_modal
xdg-toplevel-tag: real WXdgToplevelSurface::tag() equals client-set value
fractional-scale: real WOutput::scale() vs preferred_scale (round(scale×120))
single-pixel-buffer: real wlr_surface::current.buffer_width/height == 1×1 on mapped toplevel
viewporter: real wlr_surface::current.viewport dst state after set_destination(320,240)
alpha-modifier: real wlr_alpha_modifier_surface_v1_state::multiplier transitions 0.0 → 1.0
ext-session-lock: real WSessionLock::isLocked() == true after locked event

Test results

All 24 tests pass on headless backend (WLR_BACKENDS=headless, WLR_RENDERER=pixman).

Closes #1332 (resubmitted with correct commit author).

Multica: WM-328

sourcery-ai

Sorry @deepin-wm, your pull request is larger than the review limit of 150,000 diff characters

deepin-ci-robot · 2026-08-26T01:50:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-wm

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2026-08-26T09:32:08Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

deepin-bot · 2026-08-28T03:23:32Z

TAG Bot

New tag: 0.9.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1348

zzxyb · 2026-09-01T05:30:02Z

+	}
+
+	struct wp_alpha_modifier_v1 *manager =
+		client_bind(&conn, "wp_alpha_modifier_v1", &wp_alpha_modifier_v1_interface, 1);


"wp_alpha_modifier_v1"应该可以使用wp_alpha_modifier_v1_interface中的name替代

zzxyb · 2026-09-01T05:30:31Z

+
+	struct wp_alpha_modifier_v1 *manager =
+		client_bind(&conn, "wp_alpha_modifier_v1", &wp_alpha_modifier_v1_interface, 1);
+	if (!manager) {


if (manager == NULL)

zzxyb · 2026-09-01T05:31:58Z

+	struct wp_alpha_modifier_v1 *manager =
+		client_bind(&conn, "wp_alpha_modifier_v1", &wp_alpha_modifier_v1_interface, 1);
+	if (!manager) {
+		fprintf(stderr, "alpha-modifier: failed to bind wp_alpha_modifier_v1\n");


使用wlr_log_errno，里面有strerror(errno)可以方便打印内存申请为什么报错

zzxyb · 2026-09-01T05:33:09Z

+		wp_alpha_modifier_v1_get_surface(manager, tc.surface);
+	if (!am_surface) {
+		fprintf(stderr, "alpha-modifier: get_surface returned NULL\n");
+		wp_alpha_modifier_v1_destroy(manager);


manager为什么不释放？

zzxyb · 2026-09-01T05:34:20Z

+
+	wp_alpha_modifier_surface_v1_destroy(am_surface);
+	wp_alpha_modifier_v1_destroy(manager);
+	xdg_toplevel_client_destroy(&tc);


manager没释放

Add comprehensive E-level (end-to-end) and P-level (protocol-level) tests for all 24 standard wayland-protocols served by Treeland/wlroots at runtime, plus xdg-shell coverage via shared fixture. Coverage breakdown: - 23 E-level tests (end-to-end business-level with production state readback) - 1 P-level test (ext-image-copy-capture-v1, blocked by headless GPU limitation) E-level tests verify real production state through: - wlroots handle readback (wlr_seat, wlr_idle_notifier, wlr_pointer_gestures) - wl_resource_get_user_data for protocols with private d-pointer handles - SurfaceWrapper shellSurface() dynamic_cast for xdg-foreign parent readback - ShellHandler::surfaceWrapperAdded signal for surface lifecycle tracking Protocols covered (24 tested + 1 implicit): alpha-modifier, cursor-shape, ext-data-control, ext-foreign-toplevel-list, ext-idle-notify, ext-image-copy-capture, ext-session-lock, fractional-scale, idle-inhibit, pointer-constraints, pointer-gestures, primary-selection, relative-pointer, security-context, single-pixel-buffer, text-input-v1, text-input-v3, viewporter, xdg-activation, xdg-decoration, xdg-dialog, xdg-foreign, xdg-output, xdg-toplevel-tag, (xdg-shell implicit) All 55 protocol tests pass in headless CI (WLR_BACKENDS=headless, WLR_RENDERER=pixman). C test client code follows wlroots coding style. 为 wayland-protocols 全部 24 个标准协议添加 E 级与 P 级测试覆盖，复用 PR linuxdeepin#1297 建立的测试框架与 wayland-protocol-test skill。 Log: 扩展协议测试覆盖至全部标准 wayland 协议 Influence: 新增 24 个标准协议测试，无头 CI 全部通过，增强协议回归保障。

…context-v1 test CI failed with -Werror because snprintf was used without including <stdio.h>. Add the missing include.

deepin-bot · 2026-09-10T11:49:39Z

TAG Bot

New tag: 0.10.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1392

sourcery-ai Bot reviewed Aug 26, 2026

View reviewed changes

deepin-wm force-pushed the feat/wayland-protocols-test-coverage branch 2 times, most recently from 84c7804 to 9125186 Compare August 26, 2026 09:31

deepin-wm force-pushed the feat/wayland-protocols-test-coverage branch 5 times, most recently from f0482f5 to 50324cf Compare August 27, 2026 10:18

deepin-wm force-pushed the feat/wayland-protocols-test-coverage branch 2 times, most recently from 59c3c86 to f716da5 Compare September 1, 2026 01:46

zzxyb requested changes Sep 1, 2026

View reviewed changes

deepin-wm force-pushed the feat/wayland-protocols-test-coverage branch from f716da5 to d008a32 Compare September 1, 2026 07:22

deepin-wm force-pushed the feat/wayland-protocols-test-coverage branch from 76414e8 to 2dab4c5 Compare September 1, 2026 07:48

fix: add missing #include <stdio.h> for snprintf in wayland-security-…

0668d0b

…context-v1 test CI failed with -Werror because snprintf was used without including <stdio.h>. Add the missing include.

Navigation Menu

Uh oh!

tests/protocols: add 24 standard wayland-protocols tests served by Treeland - #1336

tests/protocols: add 24 standard wayland-protocols tests served by Treeland#1336
deepin-wm wants to merge 2 commits into
linuxdeepin:masterfrom
deepin-wm:feat/wayland-protocols-test-coverage

deepin-wm commented Aug 26, 2026 •

edited

Loading

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

deepin-ci-robot commented Aug 26, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026 •

edited

Loading

Uh oh!

deepin-bot Bot commented Aug 28, 2026

Uh oh!

zzxyb Sep 1, 2026

Uh oh!

zzxyb Sep 1, 2026

Uh oh!

zzxyb Sep 1, 2026

Uh oh!

zzxyb Sep 1, 2026

Uh oh!

zzxyb Sep 1, 2026

Uh oh!

deepin-bot Bot commented Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

deepin-wm commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Coverage levels

E-level tests

Test results

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

deepin-ci-robot commented Aug 26, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepin-bot Bot commented Aug 28, 2026

Uh oh!

zzxyb Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

zzxyb Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

zzxyb Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

zzxyb Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

zzxyb Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

deepin-bot Bot commented Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

deepin-wm commented Aug 26, 2026 •

edited

Loading

github-actions Bot commented Aug 26, 2026 •

edited

Loading