Skip to content

fix(waylib): unify toplevel parent change notifications - #1360

Open
zzxyb wants to merge 1 commit into
linuxdeepin:masterfrom
zzxyb:fix
Open

fix(waylib): unify toplevel parent change notifications#1360
zzxyb wants to merge 1 commit into
linuxdeepin:masterfrom
zzxyb:fix

Conversation

@zzxyb

@zzxyb zzxyb commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Replace the protocol-specific XDG and XWayland parent change signals with WToplevelSurface::parentSurfaceChanged. Keep typed parent getters for C++ callers while exposing only the common parentSurface property, avoiding invalid moc notifier checks and preserving parent-container updates.

Log: unify XDG and XWayland parent surface notifications
PMS: BUG-371095
Influence: toplevel parent tracking and Qt meta-object generation

Summary by Sourcery

Unify toplevel parent-change notifications across XDG and XWayland surfaces.

Bug Fixes:

  • Unify XDG and XWayland toplevel parent-change notifications through the common parentSurfaceChanged signal, preserving parent-container and foreign-toplevel updates.

Enhancements:

  • Expose the shared parentSurface property while removing protocol-specific parent properties and signals to ensure consistent Qt meta-object behavior.
  • Retain typed protocol-specific parent getters for C++ callers while routing parent-surface access through the common interface.

Replace the protocol-specific XDG and XWayland parent change signals
with WToplevelSurface::parentSurfaceChanged. Keep typed parent getters
for C++ callers while exposing only the common parentSurface property,
avoiding invalid moc notifier checks and preserving parent-container
updates.

Log: unify XDG and XWayland parent surface notifications
PMS: BUG-371095
Influence: toplevel parent tracking and Qt meta-object generation
@zzxyb
zzxyb requested a review from zccrs August 31, 2026 08:59
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zzxyb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-bot

deepin-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 0.10.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants