fix(harness): make wire-demo 4.2b hooks-doctor advisory when 4.2 passes#174
Merged
Conversation
…passes hermes hooks doctor exits non-zero + flags 'modified since approval' after every agentkeys wire rewrite (Hermes pins the hook hash at first-use consent; auto-accept doesn't refresh a modified-but-allowlisted hook), so a healthy demo tripped 4.2b. Now: hard-fail only if 4.2 ALSO failed; otherwise skip/warn. Capture with || true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #164 / #171 (merged). The wire-demo step
4.2b hooks doctorhard-failed even when the hooks were healthy, becausehermes hooks doctor:⚠ script modified since approvalafter everyagentkeys wirerun (Hermes pins each hook script's hash at first-use consent;hooks_auto_accept: truedoes not refresh an already-allowlisted-but-modified hook), andThe hooks themselves were always
✓ allowedand✓ produced valid JSON.4.2(the deterministichermes hooks test pre_llm_callmemory-injection check) is the authoritative pass/fail —4.2bis a secondary structural check.Change
harness/phase1-wire-demo.sh—4.2b:4.2also failed; otherwise downgrade to askip/warning with the re-consent hint.hermes hooks doctor 2>&1 || trueso its non-zero exit doesn't truncate the grep.No behavior change to the contracts or the authoritative
4.2check.🤖 Generated with Claude Code