Skip to content

chore(pinact): pin/update GitHub Actions #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidliu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(pinact): pin/update GitHub Actions #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/changeset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ jobs:
NPM_CONFIG_PROVENANCE: true
steps:
- name: Checkout Repo
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0

- name: Use Node.js 24
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 24 # NPM 11.5.1+ required for OIDC trusted publishing
cache: yarn
Expand All @@ -41,7 +41,7 @@ jobs:

- name: Create Release Pull Request or Publish to npm
id: changesets
uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1.9.0
uses: changesets/action@198f833dd7d863100ea6e28967bc9a9fdefadb0a # v2.1.0

@devin-ai-integration devin-ai-integration Bot Sep 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Release workflow fails before publishing

Every release run using changesets/action v2.1.0 rejects the installed Changesets CLI v2.29.8. The legacy version and publish inputs also fail v2 validation.

Learn more

Changesets Action v2 requires Changesets CLI v3 and validates that requirement before selecting release mode. This repository declares @changesets/cli 2.29.8 in package dependencies, so each run exits before creating a version pull request or publishing. After upgrading the CLI, the action still rejects the old workflow input names because v2 renamed them to version-script and publish-script. The token configuration also needs migration to the github-token input if a custom token is intended; setting only GITHUB_TOKEN no longer configures v2.

Example: A push to main starts Release. Dependency installation provides Changesets CLI 2.29.8, then the action reports that CLI v2 is unsupported and publishes nothing.

Recommended fix: Either retain Changesets Action v1, or migrate the repository atomically to Changesets CLI v3. For v2, rename version to version-script and publish to publish-script, and pass any custom token through github-token. Verify that ci:publish preserves CHANGESETS_OUTPUT so the action can detect published packages.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

with:
version: yarn ci:version
publish: yarn ci:publish
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/native_build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ jobs:
android-compile:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: set up JDK 17
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
with:
java-version: '17'
distribution: 'adopt'

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
cache: 'yarn'
Expand Down Expand Up @@ -54,9 +54,9 @@ jobs:
ios-compile:
runs-on: macos-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
cache: 'yarn'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pinact_update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Install aqua (installs pinact)
uses: aquaproj/aqua-installer@96a9bc20066c5bf5e275b41019cfc165b25f4e2e # v4.0.5
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22

Expand Down
Loading