Dynacast support for data tracks#1662
Conversation
|
| optional DataTrackSchemaId schema = 6; | ||
|
|
||
| // Whether dynacast is enabled for this track. | ||
| bool is_dynacasted = 7; |
There was a problem hiding this comment.
I would drop this if not used. Easier to add later if needed. Just thinking about the feature, this should be needed in the model?
| optional DataTrackSchemaId schema = 5; | ||
|
|
||
| // Whether dynacast is enabled for this track. | ||
| bool is_dynacasted = 6; |
|
|
||
| // Number of participants currently subscribed to the track. Used | ||
| // by the publisher when dynacast is enabled for the track. | ||
| uint32 subscriber_count = 2; |
There was a problem hiding this comment.
this can be a boolean, I think counter is also fine, but it may not be accurate always, but that should be fine.
There was a problem hiding this comment.
Just curious, when you say it may not always be accurate, do you mean it might take time to become consistent with the actual subscriber count?
There was a problem hiding this comment.
Yeah. I think "not always accurate" is a bit of poor framing on my part. What I meant is that if the room is spread across many regions, inter-region messages have to propagate to the publisher node indicating interest from remote nodes and then back to the publisher. I say "poor framing" because that notification has to traverse the network. So, there is no magic to instantly get the subscriber count. In a single node case, it is instantaneous, so it will look right all the time. That's what I meant by not always accurate if it is not from a single node room.
The other point about using boolean is that you just have to send it when count becomes non-zero or zero. But, if you are using count, you have to technically send it anytime it changes. Again, that does not make it inaccurate, but inefficient for the purposes of dynacast, i. e. too many notifications.
There was a problem hiding this comment.
Thanks for the info!
2 participants
Closes BOT-446