webrtc-sys: don't panic when C++ hands us a malformed RtcError string#1098
Open
c-tonneslan wants to merge 1 commit into
Open
webrtc-sys: don't panic when C++ hands us a malformed RtcError string#1098c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
The unsafe `RtcError::from(&str)` wrapper called `.expect("malformed
serialized RtcError")` on the `parse()` result. C++ can hand us a
string that doesn't match the fixed-width hex header — empty `what()`
on participant disconnect is the case in livekit#944 — and that panic took
out the caller's task.
Fall back to a generic `RtcErrorType::None` and stash the raw string
in `message` so the error still surfaces something useful.
Closes livekit#944.
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #944.
The unsafe
RtcError::from(&str)wrapper was.expect("malformed serialized RtcError")on the innerparse()Option, which panicked the caller's task whenever C++ handed across a string that didn't match the fixed-width hex header. Per #944 that happens on participant disconnect / call end (emptywhat()).Fall back to a generic
RtcErrorType::Noneand put the raw input inmessageso the error still surfaces something useful instead of taking down the task.Added a quick test covering the empty-string and non-hex cases that used to panic.