Improved data tracks depacketizer to support mutliple in flight packets#1101
Open
ladvoc wants to merge 2 commits into
Open
Improved data tracks depacketizer to support mutliple in flight packets#1101ladvoc wants to merge 2 commits into
ladvoc wants to merge 2 commits into
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
1egoman
approved these changes
May 18, 2026
Comment on lines
+128
to
130
| if result.drop_error.is_none() { | ||
| result.drop_error = Some(evicted); | ||
| } |
Contributor
There was a problem hiding this comment.
thought: It it worth logging the drop_errors which aren't being returned here so they are at least surfaced to the user somehow?
| info: info.clone(), | ||
| publisher_identity, | ||
| decryption_provider: None, | ||
| max_partial_frames: Arc::new(AtomicUsize::new(1)), |
Contributor
There was a problem hiding this comment.
nitpick: It might be worth making this max_partial_frames value default of 1 a constant - it is used enough (at least a few spots) where I think it would be beneficial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent to the implementation in: livekit/client-sdk-js#1923