CI cleanups#633
Open
tavip wants to merge 6 commits intolkl:masterfrom
Open
Conversation
DMA_OPS was renamed to ARCH_HAS_DMA_OPS in Linux 6.12. This breaks DMA and PCI support. We did not catch this issue because we were using an older qemu in CI which did not route NVME requests through the iommu. Signed-off-by: Octavian Purdila <tavip@google.com>
ddiss
approved these changes
May 8, 2026
ddiss
left a comment
ddiss
left a comment
There was a problem hiding this comment.
looks good, thanks! a few minor comments (feel free to ignore).
| char last; | ||
|
|
||
| printf(" log: |\n"); | ||
| printf(" log: |1\n"); |
Member
Author
There was a problem hiding this comment.
No, this tells the yaml parser to expect 1 space. Otherwise, if the kernel log is overflow and the first line has multiple spaces, it will confuse the parser. See the commit description.
tavip
force-pushed
the
ci-cleanups
branch
2 times, most recently
from
633c509 to
2bdaa6c
Compare
Instead of mounting a filesystem to test PCI VFIO just open the NVME block device and read it. Signed-off-by: Octavian Purdila <tavip@google.com>
Test Results106 files - 15 106 suites - 15 7m 6s ⏱️ +20s Results for commit 860c7bd. ± Comparison against base commit 2550325. This pull request removes 81 and adds 87 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Add support for running qemu on github and run the PCI VFIO test. Also add a couple of scripts to make it easier to run the test locally: ./tools/lkl/scripts/qemu-x86_64-make-images.sh . ./tools/lkl/scripts/qemu-x86_64-start-and-set-env.sh LKL_QEMU_TEST=1 make -C tools/lkl run-tests Signed-off-by: Octavian Purdila <tavip@google.com>
To simplify CI management remove circleci jobs that already exists on github. Signed-off-by: Octavian Purdila <tavip@google.com>
Explicitly tell the yaml parser how many spaces to expect for indentation. This avoids issues when the kernel buffer is truncated (because it overflows) and the first line contains more spaces. Signed-off-by: Octavian Purdila <tavip@google.com>
Otherwise host memcpy can be used and bypasses kasan interceptors. Unclear why the tests are passing in CI most of the time without this fix. They do fail reliably on my local environment. Signed-off-by: Octavian Purdila <tavip@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for running the PCI VFIO test from github actions. With that we can now remove the x86_64, x86_64_qemu and mingw32 jobs from CircleCI since we now have test parity in github actions.