Merged
Conversation
manon-traverse
approved these changes
Apr 10, 2026
Icohedron
approved these changes
Apr 10, 2026
joaosaffran
requested changes
Apr 10, 2026
Comment on lines
+24
to
+33
| Data: [ nan, nan, nan, nan ] | ||
| - Name: Infs | ||
| Format: Float32 | ||
| Data: [ inf, inf, inf, inf ] | ||
| - Name: NegInfs | ||
| Format: Float32 | ||
| Data: [ -inf, -inf, -inf, -inf ] | ||
| - Name: Mix | ||
| Format: Float32 | ||
| Data: [ inf, -inf, nan, 0 ] |
Contributor
There was a problem hiding this comment.
Testing nan, infs and denorm is not a good idea. IHVs don't deal with them consistently in the drivers, QC is particularly sensitive to them. And might cause false failing tests.
Contributor
|
Also, can we add the |
bob80905
added
the
test-all
joaosaffran
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds WaveActiveMin tests. Uses WaveActiveMax tests as a reference.
Fixes #913
Assisted by: Github Copilot