fast forward seeks on compressed streams#807
Open
oh6hay wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #807 +/- ##
==========================================
+ Coverage 87.84% 87.86% +0.01%
==========================================
Files 297 297
Lines 12287 12296 +9
==========================================
+ Hits 10794 10804 +10
+ Misses 1493 1492 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
compressed_stream_io.pydiscarded the uncompressor on forward seeks, making it really slow to access the stream if the use pattern consisted of a large number of (small) forward seeks. I found this bug by investigating why log2timeline/plaso failed on a stuck worker that attempted to analyze a fairly large xz compressed tarball -- enumerating the tar contents thrashed the CompressedStream because it initialized a new decompressor and decompressed the entire stream on every forward seek.The fix makes the CompressedStream retain the decompressor and when initialized, only discard it when seeking backwards, as compressed streams generally cannot be seeked backwards. Prior to the fix, small forward seeks caused the decompressor be initialized and decompress the entire stream up to the new seek position.
I included a test case that checks that 5000 forward seeks on a large xz-compressed stream of random bytes happens reasonably fast. (The compressed data shouldn't be a repeated pattern as that compresses too well, causing the test not to fail on an unfixed CompressedStream implementation)