Aggregate HA proxy line before parsing it - #286
Merged
andsel merged 7 commits intoSep 7, 2026
Merged
Conversation
Contributor
Changelog and Version ManagementNo changelog or version changes detected. You can either update them manually or use a comment command to update them automatically on merge:
Omit the entry line to use the PR title. If multiple commands are posted, the last one wins. |
Contributor
Author
|
Note for reviewer
|
donoghuc
requested changes
Sep 3, 2026
donoghuc
left a comment
donoghuc
left a comment
Contributor
There was a problem hiding this comment.
Take or leave some of these (especially the LLM one), i'll put a request change on this until we decide. But overall this is cool to see our tests catching this kind of bug!
Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
…he proxy, it's passed through and the handler removes itself from the channel's pipeline
donoghuc
approved these changes
Sep 4, 2026
donoghuc
left a comment
donoghuc
left a comment
Contributor
There was a problem hiding this comment.
lgtm. Looks like we will want a release. just need a pr_prepare comment!
Contributor
Author
|
/pr_prepare release:patch
|
github-actions Bot
added a commit
that referenced
this pull request
Sep 7, 2026
…proxy line before parsing it (#286)'
andsel
added a commit
that referenced
this pull request
Sep 7, 2026
Avoids error that could rise if the TCP stack decides to break the HA Proxy v1 headline before the newline terminator in multiple byte arrays. Adds an aggregator to collect all the bytes up to the first newline before move on to the decoding part done by DecoderImpl class. This message decoder is added only if proxy setting is enabled. Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Fix for processing the HA Proxy protocol, considering the line can be splitted in multiple buffers.
What does this PR do?
Adds an aggregator to collect all the bytes up to the first newline before move on to the decoding part done by DecoderImpl class. This message decoder is added only if proxy setting is enabled.
Why is it important/What is the impact to the user?
Avoids error that could rise if the TCP stack decides to break the HA Proxy v1 headline before the newline terminator in multiple byte arrays.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Related issues