Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The release workflow likely cannot run pnpm changeset ... from the repo root because Changesets tooling is only declared in the package subdirectory, which can break publishing.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adjusts Scribo’s release/publishing setup to align with the monorepo layout so the npm tarball contents and release workflow behave correctly when publishing from a workspace.
Changes:
- Add
packages/scribo/.npmignoreto exclude demo entrypoints/assets, tests, and build-tooling files from the published package. - Remove the unused root
.npmignorethat wouldn’t apply when publishing from the package subdirectory. - Update
.github/workflows/scribo-release.ymlaction versions and switch the publish command to a recursive workspace publish (pnpm publish -r).
File summaries
| File | Description |
|---|---|
| packages/scribo/.npmignore | Introduces package-scoped ignore rules to control published tarball contents in the monorepo. |
| .npmignore | Removes the root ignore file that wouldn’t affect package publishing in the new structure. |
| .github/workflows/scribo-release.yml | Updates release workflow action versions and adjusts publish to run through the workspace. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
49
to
+51
| title: "chore: version packages" | ||
| version: pnpm changeset version | ||
| publish: pnpm publish --access public --provenance | ||
| publish: pnpm publish -r --access public --provenance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjusts the release pipeline after the monorepo restructure.
.npmignore: moved from repo root topackages/scribo/— the root copy was never applied when publishing from the package subdirectory. The new file excludes demo app files (App.tsx,index.tsx,public/), test files, and build tooling configs (vite.config.*,tsconfig.node.json).scribo-release.yml: update action versions to matchci.yml(checkout@v7,pnpm/action-setup@v6,setup-node@v7) and switchpnpm publishtopnpm publish -rso changesets publishes through the workspace rather than from the root.Validation
npm pack --dry-runfrompackages/scriboconfirms demo files are excluded and all published exports (src/main.tsx,dist/main.d.ts,dist/scribo.css, schedule/callout entries) are present.