Skip to content

Put the CPU model in the bench cache's shared-key #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpgauth merged 1 commit into from
Sep 14, 2026
Merged

Put the CPU model in the bench cache's shared-key #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ jobs:
# The instrumented and PGO builds below use target-cpu=native, and
# without --target cargo applies RUSTFLAGS to proc macros too. A cached
# proc-macro .so compiled on a runner with a wider instruction set makes
# rustc die with SIGILL when it loads it, so the cache is keyed on the
# CPU model as well.
# rustc die with SIGILL when it loads it, so the CPU model is part of the
# cache key. It has to go in `shared-key`, not `key`: rust-cache appends
# `key` only when `shared-key` is unset, so setting both silently drops
# `key` from the cache key.
- name: Read runner CPU model
id: cpu
run: echo "model=$(lscpu | sed -n 's/^Model name:[[:space:]]*//p' | tr -c 'A-Za-z0-9\n' '-')" >> "$GITHUB_OUTPUT"
Expand All @@ -51,8 +53,7 @@ jobs:
uses: Swatinem/rust-cache@v2
with:
prefix-key: v1-bench
shared-key: x86_64-unknown-linux-gnu
key: ${{ steps.cpu.outputs.model }}
shared-key: x86_64-unknown-linux-gnu-${{ steps.cpu.outputs.model }}

- name: Install dependencies
run: mix deps.get
Expand Down