Skip to content

fix: replace bare except clauses with except Exception in llmcore.py#529

Open
Kailigithub wants to merge 1 commit into
lsdefine:mainfrom
Kailigithub:fix/llmcore-e722
Open

fix: replace bare except clauses with except Exception in llmcore.py#529
Kailigithub wants to merge 1 commit into
lsdefine:mainfrom
Kailigithub:fix/llmcore-e722

Conversation

@Kailigithub
Copy link
Copy Markdown
Contributor

修复 llmcore.py 中 17 处裸 except: 子句

修改范围

llmcore.py 中将所有裸 except: 替换为 except Exception:,涉及以下函数:

  • _load_mykeys(): 配置文件加载容错
  • _parse_claude_sse(): Claude SSE 事件解析中的 JSON 解析容错(2处)
  • _try_parse_tool_args(): 工具参数 JSON 解析容错(3处)
  • _parse_openai_sse(): OpenAI SSE 事件解析容错
  • _parse_anthropic_sse(): Anthropic SSE 解析容错
  • _parse_openai_resp_text(): OpenAI 响应解析容错
  • retry_request(): HTTP 重试逻辑中的 retry-after 解析和响应体读取容错(2处)
  • _parse_tool_calls_block(): 工具调用块 JSON 解析容错(2处)
  • tryparse(): JSON 字符串解析容错(3处)

验证

  • Python 语法检查通过 (python3 -m py_compile llmcore.py)
  • ruff E722 检查在 llmcore.py 中已全部通过 (All checks passed!)
  • 修改范围精准,仅替换 bare except:except Exception:,不改变任何业务逻辑

影响

无功能性变更。所有 except Exception: 捕获行为与原 except: 完全一致,但提供了更精确的错误类型信息,有助于生产环境调试。

Closes #476

Replace bare `except:` with `except Exception:` at 17 locations in llmcore.py covering SSE parsing, JSON parsing, retry logic, and HTTP response handling. This improves error specificity and debuggability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant